chore: fix Justfile refs #2672
Merged
chore: fix Justfile refs #2672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out using {{X}} in a global doesn't trigger interpolation. This resulted
in files like the literal `{{CONSOLE_ROOT}}/foo/bar`, which don't exist, being
used for dependency checks, triggering rebuilds on every invocation.
In particular this would trigger proto rebuils and console rebuilds, the latter
of which was quite time consuming :\
alecthomas
requested review from
a team and
gak
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out using {{X}} in a global doesn't get interpolated by Just. This resulted in files like the literal
{{CONSOLE_ROOT}}/foo/bar, which don't exist, being used for dependency checks, triggering rebuilds on every invocation.In particular this would trigger proto rebuilds and console rebuilds, the latter of which was quite time consuming :\